Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): Allow search terms distributed in different records #3759

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Sep 13, 2023

Description

This PR changes a wrong behavior in text search when searching several words. All the provided words must appear in the same record text field to match the results. With changes in this PR, the search will use all the fields to search the terms.

Refs #3731

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

This logic has been tested using a proper test for that. With the test case, I could reproduce the error and then after the fix, the test passed successfully.

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon added this to the v1.16.0 milestone Sep 13, 2023
@frascuchon frascuchon self-assigned this Sep 13, 2023
@frascuchon frascuchon merged commit 191cb85 into develop Sep 13, 2023
@frascuchon frascuchon deleted the bugfix/search-terms-in-different-fields branch September 13, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants