🚨 FEAT : highlight field after search #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithCuniah
added
the
area: ui
keithCuniah
changed the title
keithCuniah
changed the title
keithCuniah
force-pushed
the
feat/highlight-fields-after-query-search
branch
3 times, most recently
from
d16906c to
ad3e457
Compare
damianpumar
reviewed
Sep 7, 2023
frontend/components/feedback-task/field/TextField.component.vue
Outdated
Show resolved
Hide resolved
keithCuniah
changed the title
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3731-ki24f765kq-no.a.run.app |
8 tasks
frascuchon
reviewed
Sep 13, 2023
frontend/components/feedback-task/field/TextField.component.vue
Outdated
Show resolved
Hide resolved
frascuchon
added a commit
that referenced
this pull request
Sep 13, 2023
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR changes a wrong behavior in text search when searching several words. All the provided words must appear in the same record text field to match the results. With changes in this PR, the search will use all the fields to search the terms. Refs #3731 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) This logic has been tested using a proper test for that. With the test case, I could reproduce the error and then after the fix, the test passed successfully. **Checklist** - [X] I followed the style guidelines of this project - [x] I did a self-review of my code - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight record fields after applying a query search.
Note :
Closes #3697
Type of change
How Has This Been Tested