Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 2/3) #74168

Merged
merged 1 commit into from
Jan 14, 2025
Merged

refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 2/3) #74168

merged 1 commit into from
Jan 14, 2025
+73 −23

Conversation

bgw
Copy link
Member

@bgw bgw commented Dec 20, 2024 •
edited by padmaia
Loading

OperationVcs should be used with CollectiblesSource instead of Vcs because collectibles represent a side-effect or implicit extra return value of a function's execution.

Closes PACK-3719

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Dec 20, 2024
This was referenced Dec 20, 2024
Merged
Merged
Merged
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Dec 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Dec 20, 2024 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 20, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
buildDuration 25.3s 22.8s N/A
buildDurationCached 21.1s 18.3s N/A
nodeModulesSize 417 MB 417 MB ✓
nextStartRea..uration (ms) 615ms 581ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
middleware-b..fest.js gzip 670 B 670 B ✓
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 1.51 kB 1.51 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 369 kB 369 kB ✓
app-page-exp..prod.js gzip 130 kB 130 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 357 kB 357 kB ✓
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.46 MB 2.46 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/operationvc-collectibles-migration-pt2 Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 74.3 kB 75.7 kB ⚠️ +1.44 kB
Overall change 74.3 kB 75.7 kB ⚠️ +1.44 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: f1a9143

@bgw bgw requested a review from sokra December 20, 2024 04:02
@bgw bgw marked this pull request as ready for review December 20, 2024 04:07
@bgw bgw changed the base branch from bgw/operationvc-collectibles-migration-pt1 to graphite-base/74168 December 20, 2024 04:09
@bgw bgw force-pushed the graphite-base/74168 branch from 9a73684 to ad2282d Compare December 20, 2024 04:09
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from ee9840c to ab2f916 Compare December 20, 2024 04:09
@bgw bgw changed the base branch from graphite-base/74168 to canary December 20, 2024 04:10
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from ab2f916 to fc3c612 Compare December 20, 2024 04:10
@bgw bgw mentioned this pull request Dec 20, 2024
Merged
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from fc3c612 to d36441f Compare January 3, 2025 01:49
@bgw bgw mentioned this pull request Jan 3, 2025
Merged
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from d36441f to 31ebb3e Compare January 4, 2025 01:00
This was referenced Jan 4, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from 31ebb3e to 8fe26f8 Compare January 9, 2025 21:14
@bgw bgw changed the base branch from canary to bgw/turbopack-last-local January 9, 2025 21:14
@bgw bgw mentioned this pull request Jan 9, 2025
Merged
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from 108d3ba to 227e85b Compare January 10, 2025 23:45
@bgw
Copy link
Member Author

bgw commented Jan 10, 2025

ExternalEndpoint and ProjectInstance should store OperationVc and that need to be passed through to e. g. endpoint_write_to_disk_operation as we want the issues emitted by the Endpoint creating operation to the captured.

But as it's already broken currently, we could do that as separate PR

Created https://linear.app/vercel/issue/PACK-3707/capture-emitted-issues-during-endpoint-creation to track.

@bgw bgw force-pushed the bgw/turbopack-last-local branch from eba95ea to 17b494e Compare January 11, 2025 00:31
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from 227e85b to 699db11 Compare January 11, 2025 00:32
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 17b494e to 7186c13 Compare January 11, 2025 01:38
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from 699db11 to 4c8cc83 Compare January 11, 2025 01:39
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 7186c13 to 055f3a6 Compare January 11, 2025 02:09
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from 4c8cc83 to ba4d212 Compare January 11, 2025 02:10
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 055f3a6 to c0a05b9 Compare January 13, 2025 16:35
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from ba4d212 to f8c666f Compare January 13, 2025 16:38
@bgw bgw force-pushed the bgw/turbopack-last-local branch from c0a05b9 to b4da462 Compare January 13, 2025 18:05
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from f8c666f to d402bcf Compare January 13, 2025 18:06
@bgw bgw force-pushed the bgw/turbopack-last-local branch from b4da462 to f611e3d Compare January 13, 2025 19:11
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from d402bcf to e3415ec Compare January 13, 2025 19:12
@bgw bgw force-pushed the bgw/turbopack-last-local branch from f611e3d to 4c2249b Compare January 13, 2025 20:29
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from e3415ec to 907520a Compare January 13, 2025 20:30
@bgw bgw force-pushed the bgw/turbopack-last-local branch 2 times, most recently from 5ed2f16 to df1d0ab Compare January 13, 2025 22:08
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from 907520a to f6d6ede Compare January 13, 2025 22:08
@bgw bgw changed the base branch from bgw/turbopack-last-local to graphite-base/74168 January 13, 2025 22:48
@bgw bgw force-pushed the graphite-base/74168 branch from df1d0ab to 99c4dc3 Compare January 13, 2025 22:49
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from f6d6ede to d182ed9 Compare January 13, 2025 22:49
@bgw bgw changed the base branch from graphite-base/74168 to canary January 13, 2025 22:49
@bgw bgw force-pushed the bgw/operationvc-collectibles-migration-pt2 branch from d182ed9 to f1a9143 Compare January 13, 2025 22:49
@bgw bgw merged commit d989f98 into canary Jan 14, 2025
130 of 132 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 14, 2025

Merge activity

  • Jan 13, 9:06 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/operationvc-collectibles-migration-pt2 branch January 14, 2025 02:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @sokra