Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamoDB table should have backup enabled #495

Merged
merged 3 commits into from
Nov 25, 2020
Merged

DynamoDB table should have backup enabled #495

merged 3 commits into from
Nov 25, 2020

Conversation

pethers
Copy link
Contributor

@pethers pethers commented Nov 5, 2020 •
edited
Loading

@pethers pethers changed the title https://github.com/stelligent/cfn_nag/issues/463 DynamoDB table should have backup enabled Nov 5, 2020
@pethers
Copy link
Contributor Author

pethers commented Nov 10, 2020

@thegonch can you please review this ?

@pethers
Copy link
Contributor Author

pethers commented Nov 23, 2020

Can anyone at Stelligent please review this ?

arothian
arothian approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@arothian arothian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution

pethers added a commit to Hack23/sonar-cloudformation-plugin that referenced this pull request Nov 25, 2020
@pethers
Add support for cfn-nag rule W78 DynamoDB table should have backup
ec3c76a 
enabled, should be set using PointInTimeRecoveryEnabled.
stelligent/cfn_nag#463, waiting for
stelligent/cfn_nag#495 to be merged and
released.
thegonch
thegonch suggested changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@thegonch thegonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs one update to pass rubocop.

@pethers
Copy link
Contributor Author

pethers commented Nov 25, 2020

Looks good, just needs one update to pass rubocop.

Thanks for the feedback, will fix shortly.

@pethers pethers requested a review from thegonch November 25, 2020 21:32
@thegonch thegonch merged commit d9e40ed into stelligent:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arothian arothian arothian approved these changes

@thegonch thegonch thegonch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pethers @arothian @thegonch