fix "client not connected" after SFTP reconnect #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mus65
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
if the server closes the session and the client reconnects, this currently leads to a broken state because the session is re-created, but the SFTP subsession is not and still references the old session. This causes all operations to fail with "client not connected" or even throwing the "An established connection was aborted by the server." exception of the old session. Always re-create the SFTP subsession to fix this. fixes sshnet#1474
mus65
force-pushed
the
clientnotconnected
branch
from
4435763 to
5777f01
Compare
|
|
|
I think those are unrelated. I can take a closer look later |
|
Tests all pass locally on linux, so probably unrelated. |
Rob-Hague
approved these changes
Sep 6, 2024
|
Does it fix #1474 (comment) as well? |
|
yes, this is also caused by the SFTP subsession referencing the old session object (and therefore re-throwing its old exception). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the server closes the session and the client reconnects, this currently leads to a broken state because the session is re-created, but the SFTP subsession is not and still references the old session.
This causes all operations to fail with "client not connected" or even throwing the "An established connection was aborted by the server." exception of the old session.
Always re-create the SFTP subsession to fix this.
Also noticed another issue while looking into this: if the session already exists, but it not connected anymore, the old instance was never disposed.
fixes #1474