[FluidStack] Add Nvlink Accelerator Mappings #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks for updating the mapping @mjibril! The changes look good to me.
Comment on lines
+21
to
+22
| 'H100_NVLINK_80GB': 'H100', | ||
| 'A100_NVLINK_80GB': 'A100-80GB', |
There was a problem hiding this comment.
Nice! It seems I getting the following "failed to map" list, do we want to add them as well?
Could not map QUADRO_RTX_5000_16GB
Could not map RTX_A4500_16GB
Could not map QUADRO_RTX_4000_12GB
Could not map RTX_A6000_24GB
Could not map Quadro_P5000_12GB
Could not map QUADRO_P5000_16GB
There was a problem hiding this comment.
Not really. I will suppress these.
* Add A100-80GB and H100 Nvlink accelerator mappings * Remove custom/configurable plans
mjibril
force-pushed
the
fluidstack-add-accelerator-mappings
branch
from
39501ff to
3b8133c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add A100-80GB and H100 Nvlink accelerator mappings
Remove custom/configurable plans
Changes Description
Tests ran
sky launchpython sky/clouds/service_catalog/data_fetchers/fetch_fluidstack.pyTested (run the relevant ones):
bash format.shsky launchpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh