test: test_fun_args #55815
Closed
test: test_fun_args #55815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@ze42 This needs to be opened against the |
Validate we properly have fun arguments in job cache - for direct minion - for a minion called via syndic
|
@dwoz ok, thanks for the info. Rebased, and changed the PR to reflect that. |
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate we properly have fun arguments in job cache
What does this PR do?
Just one more test.
Note: from my test, it fails on
v2018.3.3, works onv2018.3.4Including the test ensure we do not get regression on that part.
What issues does this PR fix or reference?
Partialy related to #45823
The result is still not present in the mentioned event, but at least the job cache seems to have the proper load info.
Tests written?
Yes. It is only a test.
Commits signed with GPG?
Yes