fix: UI Jobs streams are not cleaned up after PR is closed #5359
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe1981al
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
Update `func (p *PullClosedExecutor) CleanUpPull` to use the updated definition of `PullInfo` Signed-off-by: joe1981al <[email protected]> Signed-off-by: Joseph McDonald <[email protected]>
Signed-off-by: Joseph McDonald <[email protected]>
chenrui333
reviewed
Feb 27, 2025
Comment on lines
+90
to
+95
| PullNum: pull.Num, | ||
| Repo: pull.BaseRepo.Name, | ||
| RepoFullName: pull.BaseRepo.FullName, | ||
| ProjectName: project.ProjectName, | ||
| Path: project.RepoRelDir, | ||
| Workspace: project.Workspace, |
There was a problem hiding this comment.
can you also add unit tests for such changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
func (p *PullClosedExecutor) CleanUpPullto use the updated definition of `PullInfowhy
PullInfoPullInfowasn't updated in function used to cleanup job info, so matches were not found in the mappingtests
references