Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace std::any with a custom solution. #20251

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Replace std::any with a custom solution. #20251

merged 1 commit into from
Feb 5, 2025

Conversation

zhangskz
Copy link
Member

@zhangskz zhangskz commented Feb 5, 2025

std::any leads to compiler errors in some versions of gcc during constructibility trait checks.

Now that we can guarantee it, return by reference to avoid extra costs in copies.

PiperOrigin-RevId: 723478744

Cherry-pick of ef309f0

`std::any` leads to compiler errors in some versions of gcc during
constructibility trait checks.

Now that we can guarantee it, return by reference to avoid extra costs in
copies.

PiperOrigin-RevId: 723478744
@zhangskz zhangskz merged commit 6250d09 into 30.x Feb 5, 2025
206 checks passed
@zhangskz zhangskz deleted the backport-gcc-fix branch February 5, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants