-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new @primer/brand-css package #924
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 33fdd1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excuse the review of a Draft, but spotted this and wanted to mention before I forgot 🙂
entry.name.endsWith('.module.css') && | ||
!entry.name.includes('stories') && | ||
!entry.name.includes('features') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this would be a little bit more robust going forward?
entry.name.endsWith('.module.css') && | |
!entry.name.includes('stories') && | |
!entry.name.includes('features') | |
/^\w+\.module\.css$/.test(entry) |
That matches abc.module.css
but not abc.xyz.module.css
. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to match abc.xyz.module.css
? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I didn't think so, I thought all of our main CSS was stored in the abc.module.css
file.
I was only thinking that a rogue css file could make its way in to the library if it doesn't contain stories
or features
. If you'd prefer it this way round though feel free to disregard this.
Summary
Closes https://github.com/github/primer/issues/3658
List of notable changes:
What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: