[#11186] Change gRPC UNARY response based on header value #11215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11215 +/- ##
=========================================
Coverage 36.99% 36.99%
- Complexity 12046 12048 +2
=========================================
Files 3980 3982 +2
Lines 97903 97938 +35
Branches 10418 10423 +5
=========================================
+ Hits 36215 36230 +15
- Misses 58713 58732 +19
- Partials 2975 2976 +1 ☔ View full report in Codecov by Sentry. |
feelform
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Good equals and hashCode implemetations
feelform
reviewed
Jul 3, 2024
| @@ -49,7 +50,7 @@ public SimpleRequestHandlerAdaptor(String name, DispatchHandler<REQ, RES> dispat | |||
| public void request(Message<? extends REQ> message, StreamObserver<? extends RES> responseObserver) { | |||
| try { | |||
| final ServerRequest<? extends REQ> request = serverRequestFactory.newServerRequest(message); | |||
| final ServerResponse<? extends RES> response = new GrpcServerResponse<>(responseObserver); | |||
| final ServerResponse<? extends RES> response = new GrpcServerResponse<>(responseObserver, ServerContext.getAgentInfo().isRetryFriendlyResponse()); | |||
There was a problem hiding this comment.
Could you check create new GrpcServerResponse type for the RetryFriendlyResponse?
There was a problem hiding this comment.
fixed with new GrpcRetryFriendlyServerResponse class
| } | ||
|
|
||
| @Override | ||
| public void write(final T message) { | ||
| Objects.requireNonNull(message, "message"); | ||
|
|
||
| if (retryFriendlyResponse) { |
There was a problem hiding this comment.
Could you check create new GrpcServerResponse type for the RetryFriendlyResponse?
donghun-cho
force-pushed
the
grpc_retry_header
branch
from
0338829 to
9b2ccc1
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.