-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 68007: Orphan DaemonSet when deleting with --cascade option set #20793
Conversation
lgtm, could we maybe add a test for this? |
I wouldn't bother, this is ONLY in 3.11, the next release does not have this code path. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
New changes are detected. LGTM label has been removed. |
Fixed the error @tnozicka pointed out. /hold cancel Re-applying labels back. |
@deads2k not sure who will be in charge of the next rebase, but heads up that although this is a valid upstream PR it should be dropped during next rebase since this path is removed in 1.12. |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1623352
/assign @mfojtik