Fix issue where routes are not cleaned up when a namespace label is deleted or updated. #20579
Conversation
deleted or updated. fixes bugz #1613163
openshift-ci-robot
added
sig/network-edge
size/S
| // we make locally in processNamespace() will be immediately | ||
| // reflected to plugins in the chain beneath us. This creates | ||
| // cleanup issues as old == new in Plugin.HandleNamespaces(). | ||
| namespaces := sets.NewString(c.FilteredNamespaceNames.List()...) |
There was a problem hiding this comment.
Yes, processNamespace() is synchronous but Host admitter and Unique status plugins are holding reference to the FilteredNamespaceNames and any subsequent changes in processNamespace() are immediately reflected in those plugin.
|
@pravisankar PTAL |
|
/retest |
|
/skip |
|
/test all |
| // we make locally in processNamespace() will be immediately | ||
| // reflected to plugins in the chain beneath us. This creates | ||
| // cleanup issues as old == new in Plugin.HandleNamespaces(). | ||
| namespaces := sets.NewString(c.FilteredNamespaceNames.List()...) |
There was a problem hiding this comment.
Yes, processNamespace() is synchronous but Host admitter and Unique status plugins are holding reference to the FilteredNamespaceNames and any subsequent changes in processNamespace() are immediately reflected in those plugin.
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, pravisankar, ramr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
Fix an issue where routes are not cleaned up if a namespace label is deleted or updated.
fixes bugz #1613163
/cc @openshift/sig-network-edge