Update webhook #17668
Update webhook #17668
Conversation
There was a problem hiding this comment.
I like the new approach, but for now I'd prefer to still also keep the original json + ssh code at the top as well, just so that zebi continues to receive builds and keep its file system up to date just in case we suddenly need to revert back to zebi within the next little while.
appveyor.yml
Outdated
| url: https://api.nvaccess.org/appveyor/hook | ||
| authorization: Bearer %APPVEYOR_WEBHOOK_TOKEN% | ||
| request_timeout: 5 # minutes | ||
| # Deploy on all branches including PRs (https://www.appveyor.com/docs/deployment/#pull-requests) |
There was a problem hiding this comment.
I think this is fine at least to test that the webhook is deploying correctly. But I'd prefer not to actually merge this particular change. PR builds are usually only used as a check, and can be already downloaded directly from appveyor artifacts. I would not want to cause confusion and or expectations about what NV access offers. We should only do try builds, snapshots and releases.
There was a problem hiding this comment.
Ah ok, I misunderstood you last night. I'll fix this so limited try builds are kept and PR builds are not.
seanbudd
added
the
conceptApproved
Try using the deploy webhook the AppVeyor way; we should be able to pass those variable in the environment instead of setting up a custom deploy pipeline. Using the native way allows deploys to be retried via the UI, which is very helpful. https://www.appveyor.com/docs/deployment/webhook/
Try using the deploy webhook the AppVeyor way; we should be able to pass those variable in the environment instead of setting up a custom deploy pipeline.
Using the native way allows deploys to be retried via the UI, which is very helpful.
https://www.appveyor.com/docs/deployment/webhook/