Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fpp-to-layout tool #528

Merged
merged 22 commits into from
Dec 11, 2024
Merged

Add fpp-to-layout tool #528

merged 22 commits into from
Dec 11, 2024

Conversation

jwest115
Copy link
Collaborator

@jwest115 jwest115 commented Nov 7, 2024

  • Added fpp-to-layout tool for generating layout text files for all connections in an FPP topology
  • Added unit tests for testing the different types of connections graphs (pattern, direct) as well as multiple topologies and duplicate topologies
  • Updated user guide and wiki to include new tool (wiki updates are here)

Closes #524.

@jwest115 jwest115 changed the title Issue 524 Add fpp-to-layout tool Nov 8, 2024
@jwest115 jwest115 requested a review from bocchino November 8, 2024 01:50
@jwest115 jwest115 marked this pull request as ready for review November 8, 2024 01:50
@bocchino
Copy link
Collaborator

bocchino commented Dec 3, 2024

Looks good! We discussed two updates:

  1. When generating layout directories, first delete any directory with that name, so we don't have any old files hanging around in the new directory.
  2. In the unit tests, rename the layout reference directories to X.ref instead of XRef.

After these changes, it will be ready to merge!

@jwest115
Copy link
Collaborator Author

jwest115 commented Dec 5, 2024

@bocchino I made the 2 adjustments you noted above and re-generated the test ref files. Let me know if you have any questions, etc.

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I see the changes.

@jwest115 jwest115 merged commit a2bdd78 into nasa:main Dec 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fpp-to-layout tool
2 participants