Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS SES Node): Encode template parameters properly #13570

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

riascho
Copy link
Contributor

@riascho riascho commented Feb 27, 2025

This PR ensures proper encoding for the template params used in createTemplate and updateTemplate. This is to improve the handling of special characters being passed in.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@riascho riascho changed the title fix(AwsSes) Node: Encode template parameters properly fix(AwsSes Node): Encode template parameters properly Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Aws/SES/AwsSes.node.ts 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ShireenMissi ShireenMissi changed the title fix(AwsSes Node): Encode template parameters properly fix(Aws Ses Node): Encode template parameters properly Feb 27, 2025
@ShireenMissi ShireenMissi changed the title fix(Aws Ses Node): Encode template parameters properly fix(Awsses Node): Encode template parameters properly Feb 27, 2025
@ShireenMissi ShireenMissi changed the title fix(Awsses Node): Encode template parameters properly fix(AWS SES Node): Encode template parameters properly Feb 27, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant