Implement shared "applyRefactorings'" function #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prep for moving many of them over to the API apply function.
The original limited `applyRefactorings` is still exposed, but the logic of both that and `runPipe` is now shared, allowing API users to set additional options such as language settings or implement custom hint application loops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original limited
applyRefactoringsis still exposed, but the logic of both that andrunPipeis now shared by a single function, which allows API users to set additional options such as language settings or implement custom hint application loops.Done in response to #41 and motivated by the new functionality exposed in #44.
This PR includes #45 (Fail with error on unrecognized language pragmas), since this moves that function and otherwise would require some manual merge resolution. But otherwise doesn't depend on it.