Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43464: operations with builders #206

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Feb 18, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43464
Staging - https://deploy-preview-206--docs-php-library.netlify.app/builders/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit 8dbc428
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/67c07aec425c2a0008cec840
😎 Deploy Preview https://deploy-preview-206--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! A few suggestions

Copy link
Contributor

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small things

Copy link
Contributor

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 404, otherwise LGTM, Thanks!

@rustagir rustagir requested review from a team and GromNaN and removed request for a team February 19, 2025 20:23
@rustagir rustagir requested a review from GromNaN February 20, 2025 14:39
@rustagir rustagir requested a review from GromNaN February 21, 2025 20:36
@rustagir rustagir changed the base branch from v1.21 to master February 28, 2025 19:00
documents. To learn more about updating documents, see the
:ref:`php-write-update` guide.

.. important:: Only $set Operator Supported in Update Documents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's confusing.
Update supports an aggregation pipeline, in that case most of the stages can be used.

Or by default that's update operators that are not supported by the builder yet. They are not stages even if the syntax for $set is similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants