Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Duplicate Data Room Error and Display Subscription Modal When Limit Reached #659

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

AshishViradiya153
Copy link
Contributor

This PR fix the issue: #652

  • Fix error mesage
  • Show update plan modal when limit reached
  • The data room box name appears cut off at the bottom; this has also been fixed.

image
image

If we directly show the "Upgrade Plan" button, users will never encounter an error. However, if we allow them to duplicate the data room even after reaching the limit, the correct error message will now be displayed instead of not showing right error message previously.

Copy link

vercel bot commented Oct 6, 2024

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for catching that

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 6:27am

@mfts mfts merged commit e7335ed into mfts:main Oct 7, 2024
4 checks passed
Copy link

oss-gg bot commented Oct 7, 2024

Awarding AshishViradiya153: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/AshishViradiya153

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants