Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete folder modal with strong prompt, added logic to delete folder with its associated files and folders #1191

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

AndrewHamal
Copy link
Contributor

What does this PR do?

Adds a "delete folder modal" with a strong prompt, and changes in the delete folder API function to delete the folder and all its associated files and folders within.

task #936

Screen.Recording.2024-10-20.at.11.12.16.PM.1.mov

what you did

While performing a delete folder operation if the folder has nested folders or files within I wrote an operation to find all folders where parentId matches the selected folder ID, write a loop function to loop through the folders if more child exists call a function to perform a delete operation to delete the folder and files.

also added a modal to show a prompt before deleting the folder.

…older and all its associated files and folder
@AndrewHamal AndrewHamal requested a review from mfts as a code owner October 20, 2024 17:51
Copy link

vercel bot commented Oct 20, 2024

@AndrewHamal is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 20, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Contributor Author

@AndrewHamal AndrewHamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the CLA Document and I hereby sign the CLA

@AndrewHamal
Copy link
Contributor Author

recheck

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. Small details but getting there!

Let me know if you have questions

@mfts
Copy link
Owner

mfts commented Oct 22, 2024

@AndrewHamal somehow the CLA assistant action doesn't recognize the comment you left. please do that again :)

@mfts mfts added revisit Currently not required but important in the future iteration-1 labels Oct 22, 2024
@AndrewHamal
Copy link
Contributor Author

@mfts sure

@AndrewHamal
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor Author

@AndrewHamal AndrewHamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done rechecking

@AndrewHamal AndrewHamal requested a review from mfts October 27, 2024 12:30
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:14am

@mfts mfts removed revisit Currently not required but important in the future iteration-1 labels Oct 31, 2024
@mfts mfts merged commit e454bba into mfts:main Oct 31, 2024
3 checks passed
Copy link

oss-gg bot commented Oct 31, 2024

Awarding AndrewHamal: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/AndrewHamal

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants