-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added delete folder modal with strong prompt, added logic to delete folder with its associated files and folders #1191
Conversation
…older and all its associated files and folder
@AndrewHamal is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read the CLA Document and I hereby sign the CLA
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. Small details but getting there!
Let me know if you have questions
@AndrewHamal somehow the CLA assistant action doesn't recognize the comment you left. please do that again :) |
@mfts sure |
I have read the CLA Document and I hereby sign the CLA |
…thub.com/mfts/papermark into task/ability-to-delete-folders
…lete from storate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done rechecking
- update copy for dataroom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Awarding AndrewHamal: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/AndrewHamal |
What does this PR do?
Adds a "delete folder modal" with a strong prompt, and changes in the delete folder API function to delete the folder and all its associated files and folders within.
task #936
Screen.Recording.2024-10-20.at.11.12.16.PM.1.mov
what you did
While performing a delete folder operation if the folder has nested folders or files within I wrote an operation to find all folders where parentId matches the selected folder ID, write a loop function to loop through the folders if more child exists call a function to perform a delete operation to delete the folder and files.
also added a modal to show a prompt before deleting the folder.