fix: pass theme option as url params

[DeepaPrasanna]

fixes #791

Summary of changes: passed mode as the url param in the notion link and update the darkMode value in Notion doc

[vercel]

@DeepaPrasanna is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

[abhay-joshi007]

/assign

[oss-gg]

The /assign command can only be used on issues, not on pull requests.

[mfts]

@DeepaPrasanna I think we have a misunderstanding.

The sender should add the ?theme=dark|light to the Notion URL when they are uploading it to Papermark.
From there we are extracting it and passing it into the NotionPage component.

The actual Papermark link does not change

[mfts]

@DeepaPrasanna please have a look at my last comment

[DeepaPrasanna]

I am really sorry for the delay. I will update within few hours.

[mfts]

I am really sorry for the delay. I will update within few hours.

No rush. I know you are also busy with other things. But great to keep this PR moving along.

[DeepaPrasanna]

I am really sorry for the delay. I will update within few hours.

No rush. I know you are also busy with other things. But great to keep this PR moving along.

@mfts Thank you for your patience :) I have taken into account your reviews and updated the code.

Pls also refer to the screen recording showing the changes.

Also, I think this may require updating docs so that users may know to send the query params for dark mode while uploading.
https://www.loom.com/share/74ed5f801a8f476fa182eb0468ff1557?sid=3de9bb42-8b69-4fa0-940e-f1ae5dd9f6a4

[DeepaPrasanna]

Hello @mfts wdyt about this?

[mfts]

Great job! Looks amazing and exactly how I imagined it.

I made minor adjustments, such as adding it to notionData instead of document and also adding it to custom domain routes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
papermark	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 26, 2024 10:37am

[mfts]

@DeepaPrasanna
Another cool idea would be to just make a button on the Notion document, that toggles dark/light mode and when toggled it changes the Notion url by appending / removing the ?mode=dark url query param.

Perhaps a task for a new PR before ossgg ends?

[DeepaPrasanna]

@DeepaPrasanna Another cool idea would be to just make a button on the Notion document, that toggles dark/light mode and when toggled it changes the Notion url by appending / removing the ?mode=dark url query param.

Perhaps a task for a new PR before ossgg ends?

It seems a cool one! Am I correct in assuming that you are here referring to the document shown when hitting the papermark link? If yes, it gives the user handle theme too, which will be enhancing ux

[oss-gg]

Awarding DeepaPrasanna: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/DeepaPrasanna