Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show UI warning to user when they need provider data but have not setup Synth yet #1926

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Feb 28, 2025

Simplify provider concerns

Previously, we had an abstract Providable implementation that given our sole usage of Synth, made working with provider data a bit confusing.

Now, all models that fetch external provider data will have a [Model]::Provided concern, which typically will expose a Model.provider class method. Now, working with the provider is a bit easier:

ExchangeRate.provider.present?
Security.provider.present?
Security::Price.provider.present?

If we add more providers in the future, the Model::Provided concern for each model will be responsible for configuring and choosing the desired provider for that type of data.

Add UI warning for Synth

If a family does not have Synth configured and meets any of the following criteria, we show a UI warning indicating that historical data is inaccurate.

  • Has accounts not denominated in their Family currency
  • Has investment trades
  • Has entries not denominated in their Family currency

CleanShot 2025-02-28 at 11 25 10

@zachgoll zachgoll linked an issue Feb 28, 2025 that may be closed by this pull request
1 task
…ui-warning-when-exchange-rates-are-missing-on-self-hosted-instances
@zachgoll zachgoll merged commit fa02480 into main Feb 28, 2025
5 checks passed
@zachgoll zachgoll deleted the 1899-show-ui-warning-when-exchange-rates-are-missing-on-self-hosted-instances branch February 28, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show UI warning when exchange rates are missing on self hosted instances
1 participant