Feat: Data "reset" button #1913
Conversation
|
| Family.update_all(last_synced_at: nil) | ||
| Family.find_each(&:broadcast_refresh) | ||
| end | ||
| end |
There was a problem hiding this comment.
Even though we'll be deleting records across families and a self hosted instance will typically just be one family, I still think we should pass in perform(family) here and call family.sync_later at the end of this:
ExchangeRate.delete_all
Security::Price.delete_all
family.accounts.each do |account|
account.balances.delete_all
account.holdings.delete_all
end
# We can replace the Family.update_all and Family.find_each(&:broadcast_refresh) with this:
family.sync_later| }} | ||
| %> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Can we add a Current.user.admin? guard for this too?
test/system/settings_test.rb
Outdated
|
|
||
| assert_current_path settings_hosting_path | ||
| assert_text I18n.t("settings.hostings.clear_cache.cache_cleared") | ||
| end |
There was a problem hiding this comment.
Could we remove these system tests and keep all our testing for this feature in controller/job tests?
We're trying to keep the system test suite as minimal and stable as possible for CI speed and reliability, and I think we're adding in a lot of dependence on the UI structure here, which may change in the future. The most important tests I think we need for this feature is to validate that:
- Jobs actually delete the intended data
- Admins can't trigger these jobs ever, regardless of what the UI looks like (the UI guards should be purely visual aids)
app/jobs/family_reset_job.rb
Outdated
|
|
||
| # Reset last_synced_at and broadcast refresh | ||
| family.update!(last_synced_at: nil) | ||
| family.broadcast_refresh |
There was a problem hiding this comment.
Similar to above, I'd just replace these with a family.sync_later
feat: Allow admins to delete family data
feat: Allow self-hosting users to delete cached data
Close #1901