CD-i: Fix Layering #13432
Open
CD-i: Fix Layering #13432
+89
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using 2 mattes, if multiple registers trigger on the same X coordinate, the original would execute all of them. The correct behavior is to only compare against the first one that has not yet been executed.
Bug 1: When mixing was enabled but one layer is transparent, it now correctly ignores the transparent layer. Bug 2: When mixing is enabled and both layers are transparent, it now correctly shows the backdrop.
Cleans up layering logic. No visible change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 major bugs, and reduces the code by 100 lines. It also fixes a minor bug.
Bug 1: When Mixing is enabled, but one of the layers is transparent, the transparent layer would still be visible. This is now fixed.
You can validate this by checking "Why CD-i". The menu used to be tinged green, and often had ghost images. Now the ghost images are gone, and the menu correctly shows that the green overlay is only supposed to appear as a highlight on the menu button.
Bug 2: When mixing is enabled and both layers are transparent, previously no background was visible. This is now fixed.
You can validate this by checking the Validation Disc (Europe). The Background test used to appear fully black. Now you can see there is actually a color test on the background layer.
Bug 3 (minor): there was an edge case in the Matte registers. If the game is programmed such that the matte registers are not monotonically increasing in order, they could execute out of order.
I can't remember if any games have this issue. But regardless it's fixed.