Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "today" statistics are not displayed in chart view #13854

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

mobiusy
Copy link
Contributor

@mobiusy mobiusy commented Feb 17, 2025

Summary

Fixes #13105

const value = TIME_PERIOD_MAPPING[id]?.value || '-1'

Previous:

const value = TIME_PERIOD_MAPPING[id]?.value || '-1'

If TIME_PERIOD_MAPPING[id]?.value is 0, value will be "-1", this is unexpected.
Use nullish coalescing operator for default value in chart view

Current:

const value = TIME_PERIOD_MAPPING[id]?.value ?? '-1'

Screenshots

N/A

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Feb 17, 2025
@mobiusy mobiusy closed this Feb 17, 2025
@mobiusy mobiusy reopened this Feb 18, 2025
@mobiusy mobiusy changed the title fix: use nullish coalescing operator for default value in chart view fix: "today" statistics is not displayed in chart view Feb 18, 2025
@mobiusy mobiusy changed the title fix: "today" statistics is not displayed in chart view fix: "today" statistics are not displayed in chart view Feb 18, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 18, 2025
@crazywoola crazywoola merged commit f3ad3a5 into langgenius:main Feb 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statistic date range 'Today' send invalid range
2 participants