Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DefaultAzureCredential for managed identity in azure blob extention #11559

Merged

Conversation

te-chan2
Copy link
Contributor

Summary

I prefer not to save the key as an environment variable when using Dify on Azure. I would like to modify it so that when AZURE_BLOB_ACCOUNT_KEY is set to managedidentity, it uses DefaultAzureCredential to use the Managed Identity assigned to the resource.

Resolves #11558

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Dec 11, 2024
@crazywoola crazywoola requested a review from laipz8200 December 21, 2024 03:57
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2025
@crazywoola crazywoola merged commit fac83e1 into langgenius:main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use DefaultAzureCredential for managed identity in azure blob extention
2 participants