-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exceptions ignored in select code #4681
base: main
Are you sure you want to change the base?
Conversation
513756a
to
0168f33
Compare
The actual stack trace that is thrown in the test on Native unfortunately only points to internal Ktor code (on JVM it is better, but not Android). In the past the Ktor code was changed to catch and ignore these exceptions, https://youtrack.jetbrains.com/issue/KTOR-2914/java.lang.IllegalArgumentException-Failed-requirement.-in-SelectorManagerSupport. I don't know if something changed so they can be caught now, or if that was always possible already, and the stack trace doesn't help with this. There is no way to know where in the app it crashes. I feel like no longer ignoring exceptions will cause issues again, but ignoring isn't a good solution. What to do about this?
Also it seems that after failure calling |
0168f33
to
16a1cc4
Compare
Properly pass exceptions so they can be detected when using the sockets. Maybe this will also help find any remaining issues in the selection code.