Improve Jetty server initializing for customization #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the ordering of the Jetty server initization so the configureServer step can configure the connections added by the server initializer
e5l
approved these changes
Oct 7, 2024
|
Hey @amccague, thank you for the PR! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the ordering of the Jetty server initization so the configureServer step can configure the connections added by the server initializer
Subsystem
Ktor Server, Jetty Engine
Motivation
There is currently only limited means to customise the server created by the ktor server initializer.
Any logic in the
configuration.configureServerblock will always see 0 connections on the server. Whilst this is fine for adding custom connections it does not give any capacity to refine the configuration of the Jetty server connections created by Ktor.It is possible to get the configured connections on the Jetty server, if the configure server block is executed after
initializeServer().Solution
Switch the ordering of the
configuration.configureServerinvocation so the ktor created connections are visible.