Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-corners config priorty causes crash #98

Open
irfan798 opened this issue Dec 31, 2024 · 0 comments
Open

github-corners config priorty causes crash #98

irfan798 opened this issue Dec 31, 2024 · 0 comments

Comments

@irfan798
Copy link

I dont have "repository" in my package.json and did not defined github-corners option. But the updated code expects one of them to be there:

npx -y markdown-to-html-cli -s CHANGELOG.md --output ./CHANGELOG.html                                                   ✔ 
/node_modules/markdown-to-html-cli/lib/utils.js:22
        options['github-corners'] = opts['github-corners'] ?? options['github-corners'] ?? (typeof pgkData.repository === 'string' ? pgkData.repository : pgkData.repository.url);
                                                                                                                                                                             ^
TypeError: Cannot read properties of undefined (reading 'url')

This was introduced with 63a9786#diff-852d90245bbe147114049b7940720369a5dd1c564e5d1ab29b1bf8eae193cef3L28-R25

By there removal of if(pgkData.repository & so now it just expects repository to be there

jaywcjlove added a commit that referenced this issue Jan 1, 2025
github-actions bot pushed a commit that referenced this issue Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant