Use cp -rp to copy tbb libs to avoid relinking every time running make

[cielavenir]

Type

• Bug fix (non-breaking change which fixes an issue): Fixes Open3D 0.19.0 "make install" causes relink #7152
• New feature (non-breaking change which adds functionality). Resolves #
• Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

cmake -E copy_directory copies the directory unconditionally without keeping timestamp. Then make thinks that libippc*_tl_tbb.a is updated and needs relinking libOpen3D.so.

In this MR we will use rsync -rut to avoid unnecessary updating.

Checklist:

• I have run python util/check_style.py --apply to apply Open3D code style
  to my code.
• This PR changes Open3D behavior or adds new functionality.
  • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
    updated accordingly.
  • I have added or updated C++ and / or Python unit tests OR included test
    results (e.g. screenshots or numbers) here.
• I will follow up and update the code if CI fails.
• For fork PRs, I have selected Allow edits from maintainers.

Description

[update-docs]

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

[cielavenir]

oh... it is super-sad that Open3D build agent does not have rsync, I thought it should be standard package...

do you mind telling me how this PR can be improved?

[edit] yeah, so the CI passes on MacOS

[timohl]

Just a quick idea after a short glance through this PR:
Adding rsync to the dockerfile should solve this, right?
See:

Open3D/docker/Dockerfile.ci

Lines 70 to 91 in da4d8fc

	# Dependencies: basic and python-build
	RUN apt-get update && apt-get install -y \
	git \
	wget \
	curl \
	build-essential \
	pkg-config \
	zlib1g \
	zlib1g-dev \
	libssl-dev \
	libbz2-dev \
	libreadline-dev \
	libsqlite3-dev \
	libncursesw5-dev \
	xz-utils \
	tk-dev \
	libxml2-dev \
	libxmlsec1-dev \
	libffi-dev \
	liblzma-dev \
	&& if [ $BUILD_SYCL_MODULE = "ON" ]; then apt-get install -y intel-level-zero-gpu-raytracing ; fi \
	&& rm -rf /var/lib/apt/lists/*

In the bottom you can also see how to install certain dependencies depending on build flags (in this case BUILD_SYCL_MODULE, but for your PR WITH_IPP)
There is also util/install_deps_ubuntu.sh which might have to include installing rsync.

Another question:
Does rsync also work on Windows?

[cielavenir]

@timohl Thank you! Quick ideas are still welcomed!

As you points out, I'm not sure about the universal solutions on Windows.

For Ubuntu, to avoid rsync, I changed to cp -rp. It copies the file but it keeps the timestamp, so make will not complain still.

Miracly, Windows looks working as well. Is cp available on Windows? (There are too many dialects on Windows...)

[cielavenir]

Ubuntu SYCL / ubuntu-sycl (OFF) (pull_request)

+ cp /open3d-ci-sycl.tar.xz /opt/mount
cp: error writing '/opt/mount/open3d-ci-sycl.tar.xz': No space left on device
Error: Process completed with exit code 1.

Do you know about this failure? It is not my fault

[timohl]

Ubuntu SYCL / ubuntu-sycl (OFF) (pull_request)

+ cp /open3d-ci-sycl.tar.xz /opt/mount
cp: error writing '/opt/mount/open3d-ci-sycl.tar.xz': No space left on device
Error: Process completed with exit code 1.

Do you know about this failure? It is not my fault

I have seen this error before.
Should be unrelated.