-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inference] Refactor modeling attention layer by abstracting attention backends #5771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colossalai/inference/modeling/backends/pre_attention_backend.py
Outdated
Show resolved
Hide resolved
colossalai/inference/modeling/backends/pre_attention_backend.py
Outdated
Show resolved
Hide resolved
1 task
Signed-off-by: char-1ee <[email protected]>
Signed-off-by: char-1ee <[email protected]>
Signed-off-by: char-1ee <[email protected]>
1ed7f7f
to
5f398fc
Compare
char-1ee
commented
Jun 7, 2024
Signed-off-by: char-1ee <[email protected]>
Signed-off-by: char-1ee <[email protected]>
Signed-off-by: char-1ee <[email protected]>
yuanheng-zhao
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description
pip install pre-commit && pre-commit install
🚨 Issue number
📝 What does this PR do?
Refactor inference modeling files:
Current modeling under
colossalai/inference
have nested if-else conditional checks on choosing cuda/triton kernels for Attention layer computations. This PR abstracts the positional encoding and KV Cache operations intoPreAttentionBackend
, flash attention and flash decoding ops intoAttentionBackend
. Now inference modeling initializes attention backend according to configs that users give.Fix typo and naming, refactor code organizations.
Tests:


💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.