Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non null-terminated strings in gl.Strs #49

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Conversation

emidoots
Copy link

@emidoots emidoots commented Mar 6, 2016

@dmitshur
Copy link
Member

dmitshur commented Mar 6, 2016

This PR should only update conversions.go files, not package.go. I know we haven't re-generated in a while, so there will be a diff, but we should fix that separately.

@dmitshur dmitshur added this to the Pow-Wow milestone Mar 6, 2016
@emidoots
Copy link
Author

emidoots commented Mar 6, 2016

OK, will send separate PR for that

@dmitshur
Copy link
Member

dmitshur commented Mar 6, 2016

LGTM.

emidoots pushed a commit that referenced this pull request Mar 6, 2016
allow non null-terminated strings in gl.Strs
@emidoots emidoots merged commit 5e05e76 into master Mar 6, 2016
@emidoots emidoots deleted the sg/strs-no-null branch March 6, 2016 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants