fix(anomaly detection): get aggregation key from snuba data #77498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77498 +/- ##
===========================================
+ Coverage 57.38% 78.13% +20.74%
===========================================
Files 6945 6955 +10
Lines 308220 308773 +553
Branches 50449 50541 +92
===========================================
+ Hits 176883 241270 +64387
+ Misses 126537 61107 -65430
- Partials 4800 6396 +1596 |
ceorourke
reviewed
Sep 13, 2024
| @@ -102,8 +102,21 @@ def format_historical_data(data: SnubaTSResult, dataset: Any) -> list[TimeSeries | |||
| ts_point = TimeSeriesPoint(timestamp=date.timestamp(), value=count) | |||
| formatted_data.append(ts_point) | |||
| else: | |||
| # we don't know what the aggregation key of the query is | |||
| # so we should see it when we see a data point that has a value | |||
| agg_key = "" | |||
There was a problem hiding this comment.
I think this looks good, but can we add some tests?
mifu67
force-pushed
the
mifu67/anomaly-detection-bugs-4
branch
from
7c995b8 to
c2830ea
Compare
ceorourke
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't assume that the aggregation key of a snuba timeseries data point will be
"count", so we should set the aggregation key when we see a data point with an aggregation value.