Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a32nx/fms): sort runways alphabetically #9875

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BlueberryKing
Copy link
Member

@BlueberryKing BlueberryKing commented Feb 26, 2025

Fixes #[issue_no]

Summary of Changes

  • Sort runways alphabetically in departure/arrival selection screen
  • Fix not all runways being selectable as runway-only approaches because the list was too short
  • Make "Return" button on lateral and vertical revision pages return to the previous flight plan position rather than the top

Screenshots (if necessary)

Screenshot 2025-02-26 222548
Screenshot 2025-02-26 222611

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Check departure/arrival runway selection is sorted alphabetically
  • Check you can select all runways as approaches (no instrument approach, just the runway)
  • Go to the lat/vert rev page from the flight plan page, ensure that pressing "Return" puts you back to the original position on the flight plan page

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz
Copy link
Member

This will sort parallel runways in C, L, R order. Are we sure it shouldn’t be L, C, R?

@BlueberryKing
Copy link
Member Author

This will sort parallel runways in C, L, R order. Are we sure it shouldn’t be L, C, R?

It is correct according to this reference, but I'm happy to adjust this if it has been changed in newer versions of the FMS.

image

@tracernz
Copy link
Member

Nope, that’s perfect 👌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

4 participants