Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding out and lse parameters to run functions to allow user allocated output buffer #854

Merged
merged 4 commits into from
Feb 16, 2025
Merged

feat: adding out and lse parameters to run functions to allow user allocated output buffer #854

merged 4 commits into from
Feb 16, 2025

Conversation

yzh119
Copy link
Collaborator

@yzh119 yzh119 commented Feb 16, 2025 •
edited
Loading

@yzh119 yzh119 requested a review from youkaichao February 16, 2025 08:09
youkaichao
youkaichao approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to know this only requires python-side changes.

for flash-attn, the problem is tricky because they have some padding logic.

@yzh119 yzh119 merged commit 7bee1cf into main Feb 16, 2025
@zhyncs zhyncs deleted the specifying-output-in-run-apis branch February 16, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzh119 @youkaichao