Support beforetoggle/toggle events for dialog #32479
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I don't know if this is the correct change to make, but I figured a PR is maybe more productive than an issue. Right now, the dialog element emits
beforetoggle
/toggle
events that React doesn't support, as they're non bubbling and it seems all non-bubbling event listeners need to be hard coded. This PR adds support for these by adding thelistenToNonDelegatedEvent
calls to the dialog element to get these events working.Read more about these events on MDN: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/toggle_event.
How did you test this change?
I haven't tested this change.