Failing test for recoverable error when new, unrelated Suspense boundaries commit #32436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Feb 20, 2025
| const [state, setState] = React.useState(false); | ||
| renderSuspense = () => setState(true); | ||
|
|
||
| return state ? <Suspense /> : null; |
There was a problem hiding this comment.
This new Suspense boundary triggers the error. If we start out with return <Suspense /> no error is triggered.
| <Page /> | ||
| </Suspense> | ||
| </ErrorBoundary> | ||
| <Sibling /> |
There was a problem hiding this comment.
We're triggering an update in the <Sibling> tree long after <ErrorBoundary> committed yet we still get the "switched to client-side rendering" from the <ErrorBoundary> tree.
|
Comparing: 70f1d76...b117d40 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
client-side-rendering-switch-error
branch
2 times, most recently
from
5ae5713 to
9d1a228
Compare
eps1lon
commented
Feb 20, 2025
Comment on lines
1178
to
1204
| expectErrors( | ||
| errors, | ||
| [ | ||
| [ | ||
| 'Switched to client rendering because the server rendering errored:\n\n' + | ||
| theError.message, | ||
| expectedDigest, | ||
| componentStack(['Page', 'Suspense', 'ErrorBoundary', 'App']), | ||
| ], | ||
| [ | ||
| 'Switched to client rendering because the server rendering errored:\n\n' + | ||
| theError.message, | ||
| expectedDigest, | ||
| componentStack(['Page', 'Suspense', 'ErrorBoundary', 'App']), | ||
| ], | ||
| ], | ||
| [ | ||
| [ | ||
| 'The server could not finish this Suspense boundary, likely due to an error during server rendering. Switched to client rendering.', | ||
| expectedDigest, | ||
| ], | ||
| ], | ||
| ); |
There was a problem hiding this comment.
There should be no errors here since we updated an unrelated tree. That particular error was already handled by committing the error boundary.
eps1lon
force-pushed
the
client-side-rendering-switch-error
branch
from
9d1a228 to
0c0218a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found these when working on the Next.js error overlay.
How did you test this change?