Clean up enableSiblingPrerendering flag #32319
Open
+609
−1,439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 44c3d3d...0bc39f8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
jackpope
force-pushed
the
enable-sibling-prerendering-cleanup
branch
from
429a8ec to
e83bf3f
Compare
jackpope
force-pushed
the
enable-sibling-prerendering-cleanup
branch
from
bda4cb1 to
2fbfc41
Compare
jackpope
force-pushed
the
enable-sibling-prerendering-cleanup
branch
from
2fbfc41 to
e0e1662
Compare
rickhanlonii
reviewed
Feb 7, 2025
|
|
||
| ...(gate('enableSiblingPrerendering') ? ['Suspend! [Hi]'] : []), | ||
| ]); | ||
| await waitForAll(['Suspend! [Hi]', 'Loading...', 'Suspend! [Hi]']); |
There was a problem hiding this comment.
It might be worth adding comments to all these cases like:
await waitForAll([
'Suspend! [Hi]',
'Loading...',
// pre-warming
'Suspend! [Hi]']
);
rickhanlonii
reviewed
Feb 7, 2025
| @@ -2011,7 +2006,7 @@ function handleThrow(root: FiberRoot, thrownValue: any): void { | |||
| // TODO: Suspending the work loop during the render phase is | |||
| // currently not compatible with sibling prerendering. We will add | |||
| // this optimization back in a later step. | |||
| !enableSiblingPrerendering && | |||
| false && | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.