-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-compiler): implement NumericLiteral as ObjectPropertyKey #31791
Open
dimaMachina
wants to merge
9
commits into
facebook:main
Choose a base branch
from
dimaMachina:numeric-literal-as-object-property-key
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b308f0a
fix(react-compiler): implement NumericLiteral as ObjectPropertyKey
dimaMachina 59f2dd1
update test to see object with numeric key in output
dimaMachina 52249bc
update test
dimaMachina cad3a8b
Merge branch 'main' into numeric-literal-as-object-property-key
dimaMachina 9e8d664
Merge branch 'main' into numeric-literal-as-object-property-key
dimaMachina 89226f8
add `export const FIXTURE_ENTRYPOINT`
dimaMachina fe5eef5
Merge branch 'main' into numeric-literal-as-object-property-key
dimaMachina d8c069b
prettier
dimaMachina 6928ae4
Merge branch 'main' into numeric-literal-as-object-property-key
dimaMachina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...rc/__tests__/fixtures/compiler/numeric-literal-as-object-property-key.expect.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
|
||
## Input | ||
|
||
```javascript | ||
function Test() { | ||
const obj = { | ||
21: 'dimaMachina' | ||
} | ||
return <div>{obj[21]}</div> | ||
} | ||
|
||
export const FIXTURE_ENTRYPOINT = { | ||
fn: Test, | ||
params: [{}], | ||
}; | ||
|
||
``` | ||
|
||
## Code | ||
|
||
```javascript | ||
import { c as _c } from "react/compiler-runtime"; | ||
function Test() { | ||
const $ = _c(1); | ||
let t0; | ||
if ($[0] === Symbol.for("react.memo_cache_sentinel")) { | ||
const obj = { 21: "dimaMachina" }; | ||
|
||
t0 = <div>{obj[21]}</div>; | ||
$[0] = t0; | ||
} else { | ||
t0 = $[0]; | ||
} | ||
return t0; | ||
} | ||
|
||
export const FIXTURE_ENTRYPOINT = { | ||
fn: Test, | ||
params: [{}], | ||
}; | ||
|
||
``` | ||
|
||
### Eval output | ||
(kind: ok) <div>dimaMachina</div> |
11 changes: 11 additions & 0 deletions
11
...-react-compiler/src/__tests__/fixtures/compiler/numeric-literal-as-object-property-key.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
function Test() { | ||
const obj = { | ||
21: 'dimaMachina', | ||
}; | ||
return <div>{obj[21]}</div>; | ||
} | ||
|
||
export const FIXTURE_ENTRYPOINT = { | ||
fn: Test, | ||
params: [{}], | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a fixture here so that we can test evaluation with/without compilation:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also be sure to update fixtures after this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Updated! Could you also review my other contribution to the react compiler? #31792
I just pushed there similar change 🙂