This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 226
Add unit test for DeviceIOControl #503
Merged
AArnott
merged 4 commits into
dotnet:master
from
qmfrederik:fixes/device-io-control-unit-test
Jul 12, 2020
Merged
Add unit test for DeviceIOControl #503
AArnott
merged 4 commits into
dotnet:master
from
qmfrederik:fixes/device-io-control-unit-test
Jul 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmfrederik
commented
Jul 8, 2020
qmfrederik
commented
Jul 8, 2020
[Fact] | ||
public unsafe void DeviceIOControl_Works() | ||
{ | ||
const uint IOCTL_DISK_GET_DRIVE_GEOMETRY = 0x070000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common I/O codes are defined in https://docs.microsoft.com/en-us/windows/win32/api/winioctl/ , might make sense to add them to dotnet/pinvoke (as a separate effort)
AArnott
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. We can merge as-is, but if you don't mind making the int
->uint
change I suggest, I think that would be slightly better.
qmfrederik
commented
Jul 9, 2020
@AArnott Thanks, I made the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And
DISK_GEOMETRY
,MEDIA_TYPE
struct & enum along the way.