This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Add Kernel32.GetNativeSystemInfo #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
suggested changes
Jul 8, 2020
src/Kernel32/Kernel32+SYSTEM_INFO.cs
Outdated
| /// A mask representing the set of processors configured into the system. | ||
| /// Bit 0 is processor 0; bit 31 is processor 31. | ||
| /// </summary> | ||
| public int* dwActiveProcessorMask; |
There was a problem hiding this comment.
This isn't really a pointer. It's just a pointer-sized field. Let's use IntPtr here to make that clear.
src/Kernel32/Kernel32+SYSTEM_INFO.cs
Outdated
| /// <summary> | ||
| /// The architecture-dependent processor level. It should be used only for display purposes. | ||
| /// </summary> | ||
| public short wProcessorLevel; |
There was a problem hiding this comment.
ushort is more appropriate here since it's an (unsigned) WORD in native code. We'll sometimes use int instead of uint where the value is likely to be used in other .NET APIs that take int, but as a short/ushort, it's already non-standard. And I suspect ushort is accepted by int APIs implicitly anyway since the range just grows.
src/Kernel32/Kernel32+SYSTEM_INFO.cs
Outdated
| /// <summary> | ||
| /// The architecture-dependent processor revision. | ||
| /// </summary> | ||
| public short wProcessorRevision; |
There was a problem hiding this comment.
ushort is more appropriate here since it's an (unsigned) WORD in native code.
AArnott
approved these changes
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.