Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Hex erlang package provider #11493

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

TylerWitt
Copy link
Contributor

@TylerWitt TylerWitt commented Feb 5, 2025

What are you trying to accomplish?

ESL's version of erlang didn't include arm packages, and also is slightly behind in versions compared to RabbitMQ's erlang version.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@TylerWitt TylerWitt requested a review from a team as a code owner February 5, 2025 17:09
@github-actions github-actions bot added the L: elixir:hex Elixir packages via hex label Feb 5, 2025
@TylerWitt
Copy link
Contributor Author

TylerWitt commented Feb 5, 2025

@andrcuns, is it possible for you to check if this branch solves your concerns from #11350 (comment)?

@andrcuns
Copy link
Contributor

andrcuns commented Feb 5, 2025

is it possible for you to check if this branch solves your concerns from #11350 (comment)?

@TylerWitt Yep, I can confirm that with these changes arm build works again 🥳

@sachin-sandhu
Copy link
Contributor

sachin-sandhu commented Feb 6, 2025

@TylerWitt , thanks for the fix! considering going forward , what changes do we need to upgrade the erlang version (to say 27),

i.e. do we need to change following?

rabbitmq-erlang-26 ?

RUN echo "deb [signed-by=/usr/share/keyrings/net.launchpad.ppa.rabbitmq.erlang.gpg] https://ppa.launchpadcontent.net/rabbitmq/rabbitmq-erlang-26/ubuntu jammy main" >> /etc/apt/sources.list

RUN echo "deb-src [signed-by=/usr/share/keyrings/net.launchpad.ppa.rabbitmq.erlang.gpg] https://ppa.launchpadcontent.net/rabbitmq/rabbitmq-erlang-26/ubuntu jammy main" >> /etc/apt/sources.list

@TylerWitt
Copy link
Contributor Author

@TylerWitt , thanks for the fix! considering going forward , what changes do we need to upgrade the erlang version (to say 27),

i.e. do we need to change following?

rabbitmq-erlang-26 ?

RUN echo "deb [signed-by=/usr/share/keyrings/net.launchpad.ppa.rabbitmq.erlang.gpg] https://ppa.launchpadcontent.net/rabbitmq/rabbitmq-erlang-26/ubuntu jammy main" >> /etc/apt/sources.list

RUN echo "deb-src [signed-by=/usr/share/keyrings/net.launchpad.ppa.rabbitmq.erlang.gpg] https://ppa.launchpadcontent.net/rabbitmq/rabbitmq-erlang-26/ubuntu jammy main" >> /etc/apt/sources.list

I just updated these changes so that the only thing that should need to be updated is the ERLANG_MAJOR_VERSION.

@sachin-sandhu
Copy link
Contributor

@TylerWitt , thanks for the fix! considering going forward , what changes do we need to upgrade the erlang version (to say 27),
i.e. do we need to change following?
rabbitmq-erlang-26 ?

RUN echo "deb [signed-by=/usr/share/keyrings/net.launchpad.ppa.rabbitmq.erlang.gpg] https://ppa.launchpadcontent.net/rabbitmq/rabbitmq-erlang-26/ubuntu jammy main" >> /etc/apt/sources.list

RUN echo "deb-src [signed-by=/usr/share/keyrings/net.launchpad.ppa.rabbitmq.erlang.gpg] https://ppa.launchpadcontent.net/rabbitmq/rabbitmq-erlang-26/ubuntu jammy main" >> /etc/apt/sources.list

I just updated these changes so that the only thing that should need to be updated is the ERLANG_MAJOR_VERSION.

@TylerWitt , thanks a lot for simplification!

cc @abdulapopoola

Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-sandhu sachin-sandhu force-pushed the change-erlang-source branch 2 times, most recently from 9f86cff to 09b0909 Compare February 7, 2025 16:31
ESL's version of erlang didn't include arm packages, and also is slightly behind in versions compared to RabbitMQ's erlang version.
@sachin-sandhu sachin-sandhu merged commit dde2267 into dependabot:main Feb 7, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elixir:hex Elixir packages via hex
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants