Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LinkReferenceDefinition having null SourceSpan when title is present #310

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

robinst
Copy link
Collaborator

@robinst robinst commented Mar 12, 2024

Fixes #292.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (06aa3e5) to head (21fc1df).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #310      +/-   ##
============================================
- Coverage     94.75%   94.75%   -0.01%     
  Complexity      254      254              
============================================
  Files           131      131              
  Lines          4141     4140       -1     
  Branches        604      604              
============================================
- Hits           3924     3923       -1     
  Misses          108      108              
  Partials        109      109              
Files Coverage Δ
...onmark/internal/LinkReferenceDefinitionParser.java 96.96% <100.00%> (-0.03%) ⬇️

@robinst robinst merged commit 4a6b944 into main Mar 12, 2024
12 checks passed
@robinst robinst deleted the issue-292 branch March 12, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkReferenceDefinition has null sourceSpans if title included
1 participant