Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsview & ds input[DO NOT MERGE] #15322

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

dsview & ds input[DO NOT MERGE] #15322

wants to merge 41 commits into from

Conversation

hana-alice
Copy link
Contributor

Re: #

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

bofeng-song and others added 30 commits June 1, 2023 13:40
@bofeng-song
fix install failed with android studio (cocos#15251)
a8eb030
@PatriceJiang
change the return type of submodel.passes to shared_ptr (cocos#15267)
175d8a4
@dogeFu
fix : Avoid warning triggered by skin configuration on editor restore (…
98d6152 
…cocos#15220)
@arsen2010
fix inspector paste component value bug (cocos#15271)
1fc559c 
* fix paste component value bug

* fix node.active undo bug
@dogodo-cc
[Bug] feat: inspector/fbx/mountAllAnimationsOnPrefab default value is…
258ebba 
… false (cocos#15232)

* feat: inspector/fbx/mountAllAnimationsOnPrefab default value false

* feat: use getPropValue get value
@troublemaker52025
Optimize skin with post-process pipeline (cocos#15189)
07f3ded
@shrinktofit
Marionette/PoseGraph: disallow empty states in PoseNodeStateMachine (c…
f596589 
…ocos#15282)
@shrinktofit
Marionette/PoseGraph: fix that a pose node can be connected multi tim…
f9f379d 
…es (cocos#15231)
@zxx43
add reset function to call when start play (cocos#15217)
db625b6 
* add reset function to call when start play

* remove clear

* reset when stop emitting

* rename param & reuse position

* call reset in stop
@PatriceJiang
reset delegate value when cleanup scriptengine (cocos#15281)
63fe38f
@cocos-robot
[ci skip][AUTO]: Automated code generating update: 1675361 (cocos#15281…
0d1f5d0 
…) (cocos#15294)

Co-authored-by: cocos-robot <[email protected]>
@jk20012001
fix fog in legacy and surface shader (cocos#15293)
e83ac6a
@lealzhan
[fix] physx Character Controller filter bug (cocos#15291)
0c2d340
@qiuguohua
Fix harmonyos platform compilation failure. (cocos#15262)
3433939
@PatriceJiang
detect all subfolders (cocos#15297)
8d9bd2e
@shrinktofit
Marionette: adjust additive animation rule (cocos#15296)
b996489 
* Marionette: adjust additive animation rule

* Rename base -> ref

* Importer UI
@xubing0906
add setMaterialProperty function for skyboxInfo (cocos#15284)
a841f82
@2youyou2
fixed fsr param not saved (cocos#15301)
836d2a0
@lealzhan
[fix] physx misuses bullet variable (cocos#15255)
f01671f
@2youyou2
fixed fsr input size (cocos#15304)
1b7a33a
@troublemaker52025
performance optimization for onMacroPatchesStateChanged function (coc…
b5cb733 
…os#15279)
@troublemaker52025
The globalStandardSkin setting is placed on the meshRenderer component (
28d675e 
cocos#15274)
@hana-alice
sync ds view
5b4ad73
@hana-alice
dsview input
4578486
@hana-alice
input layout
5dbd0f2
@hana-alice
rpinfo update
e6aa7c7
@hana-alice
ds usage
881cb2d
@hana-alice
layout fix
59dcce5
@hana-alice
layout fix
f5b6ae2
@hana-alice
ds layout
acde5c9
@github-actions
Copy link

github-actions bot commented Jun 5, 2023 •
edited
Loading

Interface Check Report

This pull request does not change any public interfaces !

@hana-alice hana-alice requested review from star-e and bluesky013 June 5, 2023 10:27
star-e
star-e reviewed Jun 5, 2023
View reviewed changes
native/cocos/renderer/pipeline/custom/NativeExecutor.cpp Outdated
auto resIter = std::find_if(attachments.begin(), attachments.end(), [resID](const AccessStatus& status) {
return status.vertID == resID;
});

auto slotName = rasterView.slotName;
if (rasterView.accessType == AccessType::READ || rasterView.accessType == AccessType::READ_WRITE) {
slotName.insert(0, "__in");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think __in prefix is not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In shdc we process input attachment eg c0 in #pragma subpassColor c0 into __inc0.
Same time user coding like: pass.addRasterView(user_defined_c0_name, "c0", ...) according to effect, so it's still c0 in rasterView.slotName, which does not match what it is in layoutGraph.attributeIndex.
Not sure if name processing is neccesarry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in c++ and effect, __in is not used. __inc0 is an internal variable and will only be used by subpassLoad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Vulkan backend subpass input attachment will be bind in descriptor as INPUT_ATTACHMENT, this is the only usage AFAIK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I think the name is not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check the code, that's true, will remove later.

@hana-alice hana-alice changed the title dsview & ds input dsview & ds input[DO NOT MERGE] Jun 8, 2023
@hana-alice hana-alice changed the base branch from v3.8.0 to develop June 8, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@star-e star-e star-e left review comments

@bluesky013 bluesky013 Awaiting requested review from bluesky013

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.