Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/username validation sync with frontend #10

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

FlowerC9
Copy link
Contributor

@FlowerC9 FlowerC9 commented Feb 27, 2025

Describe your changes

1.Support for Non-ASCII Characters – Updated the user name handling to allow spaces and non-ASCII characters, ensuring support for diverse names across different languages and character sets.

2.Truncation of Long Names – Implemented truncation for long names to prevent UI overflow, ensuring they fit within the available space while maintaining readability in both the main UI and the user context menu.

Issue number

fixes #1561 of frontend by syncing with backend

Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.

  • (Do not skip this or your PR will be closed) I deployed the application locally.
  • (Do not skip this or your PR will be closed) I have performed a self-review and testing of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
  • I made sure font sizes, color choices etc are all referenced from the theme.
  • My PR is granular and targeted to one specific feature.
  • I took a screenshot or a video and attached to this PR if there is a UI change.

before:
Screenshot 2025-02-26 115631

after:
Screenshot 2025-02-26 210924

Summary by CodeRabbit

  • Refactor
    • Consolidated and improved name validations for user registration and edits to ensure names are trimmed, adhere to a character limit, and match required formatting.
    • Introduced clearer error messaging for empty, overly long, or invalid name entries to enhance user feedback.

Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

The changes consolidate name validation by introducing a new reusable schema, nameValidation. This schema enforces that firstName and lastName are trimmed strings with a maximum length of 50 characters and must match a specified pattern allowing letters, spaces, apostrophes, and currency symbols. Custom error messages are provided for empty inputs, excessive length, or pattern mismatches. The new schema replaces the previous direct string validations in both the registration and edit user body validation schemas.

Changes

File(s) Summary
validation/joi.js Added nameValidation schema for validating names with trim, max length, pattern rules, and custom error messages. Integrated into registration and edit user validations.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant S as Server
    participant V as Validation Module
    U->>S: Sends registration/edit request with name data
    S->>V: Uses nameValidation schema to validate firstName & lastName
    V-->>S: Returns validation result (success/error)
    S-->>U: Responds based on validation outcome
Loading

Poem

I'm a hopping rabbit in a code-filled meadow,
Skipping through validations with steps so mellow.
My new schema makes names shine bright,
Trimming errors till they’re out of sight.
With a joyful twitch and a bouncy cheer,
I celebrate clean code far and near! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5353830 and 2d82882.

📒 Files selected for processing (1)
  • validation/joi.js (2 hunks)
🔇 Additional comments (3)
validation/joi.js (3)

38-48: Well-designed name validation schema!

The new nameValidation schema effectively addresses the PR objectives by allowing spaces and non-ASCII characters in names while maintaining reasonable restrictions. The Unicode-aware regex pattern (\p{L} for letters and \p{Sc} for currency symbols) ensures international name support. The custom error messages are clear and helpful for users.


51-52: Good refactoring of the registration validation.

Using the centralized nameValidation schema improves code organization and ensures consistent validation rules between different parts of the application.


80-81: Consistent validation implementation for user edits.

Applying the same name validation rules to both registration and user editing flows ensures a consistent user experience throughout the application.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@FlowerC9
Copy link
Contributor Author

@ajhollid i have synced the backend according to the frontend could you please check and tell me do want any changes?

@ajhollid ajhollid merged commit 4332901 into bluewave-labs:develop Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants