Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index on good_jobs: [:concurrency_key, :created_at] to improve performance of throttling (#1603) #1605

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add index on good_jobs: [:concurrency_key, :created_at] to improve performance of throttling (#1603) #1605

wants to merge 7 commits into from

Conversation

Intrepidd
Copy link
Contributor

As discussed in #1603

Did I miss anything ?

@Intrepidd Intrepidd mentioned this pull request Feb 16, 2025
Open
@Intrepidd Intrepidd changed the title Add index on good_jobs: [:concurrency_key, :cerated_at] to improve performance of throttling (#1603) Add index on good_jobs: [:concurrency_key, :created_at] to improve performance of throttling (#1603) Feb 16, 2025
@Intrepidd
Copy link
Contributor Author

Looks like sorbet doesn't like the rails 8.0 migration, I'm not familiar with it, how should I go about fixing it ?

@bensheldon
Copy link
Owner

Thank you! 🙇🏻 I can fix this up and get it merged 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensheldon bensheldon bensheldon left review comments

Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Inbox
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Intrepidd @bensheldon