Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid false warning on clean up. #1755

Closed
wants to merge 1 commit into from
Closed

Conversation

slewsys
Copy link
Contributor

@slewsys slewsys commented May 11, 2024

Summary

This is an alternative to #1721, and may be closer to the original intent: if asdf is configured to preserve downloads, but the download_path directory is missing, then give warning.

Fixes: Removes false warning on clean up.

@slewsys slewsys requested a review from a team as a code owner May 11, 2024 18:31
@slewsys slewsys changed the title Avoid false warning on clean up. fix: Avoid false warning on clean up. May 12, 2024
@BraDaga
Copy link

BraDaga commented May 14, 2024

H

@Stratus3D
Copy link
Member

Hi @slewsys, sorry for the late reply here. Thanks for the PR! It looks like #1756 was already merged, and solves the same issue so I'm going to close this PR. If that PR doesn't solve the full issue please comment here and we can re-evaluate this.

@Stratus3D Stratus3D closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants