Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard input support for webplayer #269

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Conversation

ikks
Copy link

@ikks ikks commented Oct 10, 2024

Screencast from 2024-10-09 19-59-16.webm
This Pull Request adds support for keyboard presses. Related to https://github.com/orgs/asciinema/discussions/154

  • Includes a new option to not show the key presses
  • Tries to be unintrusive
  • can be toggled
  • I will open a PR for the documentation to add the new option for the player.
    Is pleasant to read your code. Cheers.

@ikks
Copy link
Author

ikks commented Oct 10, 2024

Doc is here asciinema/asciinema.github.io#11

ikks added 2 commits October 9, 2024 23:39
When we find a sequence that has not been identified, we log it
@azat
Copy link

azat commented Oct 10, 2024

It would be very useful to have an ability to configure how much last keys should be shown, in number of keys or/and time (i.e. show pressed keys for the last 3 seconds). That way you can show sequence of keys, i.e. shortcuts, which can be important.

And maybe it worth to make the timeout (how long should the keys be shown) configurable, or maybe it is synced with the screencast, i.e. it will be automatically replaced with a new key stroke, and until then, it will be visible. In this case I guess first two things will be enough.

What do you think?

@ikks
Copy link
Author

ikks commented Oct 10, 2024

@azat I understand that for emacs users and other more complex scenarios it would be needed more keypressed for the explanations. I will skip this request.

There is now a fade effect that can be tested at https://igor.tamarapatino.org/samples/asciinema/ .

@ku1ik
Copy link
Contributor

ku1ik commented Feb 2, 2025

Hey @ikks 👋

I'm glad it was easy to follow the code 😊 Thanks for this PR, I finally got to it. Just skimmed it for now but it looks pretty good. I'll review it properly in the coming days.

@ku1ik
Copy link
Contributor

ku1ik commented Feb 2, 2025

@azat good ideas. I also think those would definitely be nice to have 👍

I think we'll release the first version without too much configurability and see how it performs on real life recordings. Then we could introduce improvements/tweaks in a follow up release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants