Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Improve styles file weight #5724

Merged
merged 10 commits into from
Dec 11, 2024
Merged

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Nov 29, 2024

This PR improves the weight of the style files by removing some css files from the scss variable bundle.

FINAL:
Screenshot 2024-12-11 at 11 55 33

Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5724-ki24f765kq-no.a.run.app

@damianpumar
Copy link
Contributor

After testing it, I see many css styles...

@damianpumar
Copy link
Contributor

FROM:
Screenshot 2024-12-10 at 20 47 37

TO:
Screenshot 2024-12-10 at 20 47 45

@damianpumar
Copy link
Contributor

FROM:
Screenshot 2024-12-10 at 20 49 27

TO:
Screenshot 2024-12-10 at 20 49 35
Screenshot 2024-12-10 at 20 49 38

@damianpumar
Copy link
Contributor

I optimised the chunks splitting the CSS from 1.1 MB file into many small CSS files.

@damianpumar damianpumar changed the title Improve styles file weight 🎉 Improve styles file weight Dec 10, 2024
@damianpumar
Copy link
Contributor

Great work @leiyre removing the comments.
Screenshot 2024-12-11 at 11 36 43

@damianpumar damianpumar merged commit 21d07c9 into develop Dec 11, 2024
4 checks passed
@damianpumar damianpumar deleted the feat/improve-css-extraction branch December 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants