Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] argilla: Align questions to Resource API #5680

Merged
merged 14 commits into from
Nov 21, 2024

Conversation

frascuchon
Copy link
Member

Description

Closes #4931

Type of change

  • Refactor (change restructuring the codebase without changing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from burtenshaw November 8, 2024 08:39
@frascuchon frascuchon changed the title [REFACTOR] argilla: Align questions to Resource API. [REFACTOR] argilla: Align questions to Resource API Nov 8, 2024
Copy link
Contributor

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice refactor and alignment. One question: does the new update API method allow updating questions? If so, how and when within the dataset lifecycle?

@frascuchon
Copy link
Member Author

This looks like a nice refactor and alignment. One question: does the new update API method allow updating questions? If so, how and when within the dataset lifecycle?

Yes. This change allows users to update some values for questions. It's true that currently there is not much flexibility to change questions (titles, descriptions, some flags) but this may change in the future (adding new labels for label or span questions,...). Fields have a similar flexibility degree and can be updated from the SDK.

@frascuchon frascuchon added this to the v2.5.0 milestone Nov 14, 2024
Copy link
Contributor

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frascuchon frascuchon merged commit d6bc6f8 into develop Nov 21, 2024
7 checks passed
@frascuchon frascuchon deleted the refactor/argilla/align-question-to-resource-API branch November 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Improve handling of question models and dicts
2 participants